| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix interaction of Perl and stdbool.h |
| Date: | 2018-03-23 20:34:50 |
| Message-ID: | 5aa06ffe-5443-bcfd-136d-44153022b942@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/23/18 12:19, David Steele wrote:
> On 3/23/18 11:49 AM, Tom Lane wrote:
>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>> Fix interaction of Perl and stdbool.h
>>
>> Not sure if this broke it or it was already broken, but my compiler
>> is now very unhappy.
>>
>> In file included from /usr/lib64/perl5/CORE/perl.h:2424,
>> from plperl.h:60,
>> from SPI.xs:18:
>> /usr/lib64/perl5/CORE/handy.h:108:1: warning: "bool" redefined
>
> One way to fix this is to mark bool as defined in plperl.c:
>
> #ifndef HAS_BOOL
> # define HAS_BOOL 1
> #endif
Well, that's what we had before, but that crashed on the 4-byte bool
platforms. So the fix I pushed does that only if PostgreSQL is using
stdbool.h. It works for me on CentOS 6 now.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-23 20:48:43 | Re: pgsql: Fix interaction of Perl and stdbool.h |
| Previous Message | Peter Eisentraut | 2018-03-23 20:32:53 | pgsql: Further fix interaction of Perl and stdbool.h |