Re: No LINGUAS file yet for pg_combinebackup

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: No LINGUAS file yet for pg_combinebackup
Date: 2023-12-26 20:38:47
Message-ID: 5a986476-50eb-4d1a-a124-f946bdaff6e4@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26.12.23 13:18, Michael Paquier wrote:
> On Mon, Dec 25, 2023 at 12:48:17PM -0500, Tom Lane wrote:
>> I don't particularly care to see that warning until whenever
>> it is that the translations first get populated. Perhaps
>> we should hack up nls-global.mk to hide the warning, but
>> that might bite somebody someday. I'm inclined to just
>> add an empty LINGUAS file as a temporary measure.
>> Thoughts?
>
> I've noticed this noise as well, so +1 for the temporary empty file.

I checked that meson also complains about the missing file, except that
we hadn't equipped pg_combinebackup with NLS support in meson yet. So I
added that as well. So having the empty file is the correct solution
for both build systems. Tom has already added the empty file.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-12-26 21:03:20 Re: pg_stat_statements: more test coverage
Previous Message Peter Eisentraut 2023-12-26 19:58:55 Re: [meson] expose buildtype debug/optimization info to pg_config