| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| Date: | 2022-09-06 05:44:13 |
| Message-ID: | 5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 20.07.22 16:52, Justin Pryzby wrote:
> +/* GUC_UNIT_* are not flags - they're tested for equality */
Well, there is GUC_UNIT_MEMORY, etc. so there is an additional
constraint beyond just "pick any number". I'm not sure that "flag" and
"tested for equality" are really antonyms anyway.
I think renumbering this makes sense. We could just leave the comment
as is if we don't come up with a better wording.
> #define GUC_UNIT_KB 0x1000 /* value is in kilobytes */
> #define GUC_UNIT_BLOCKS 0x2000 /* value is in blocks */
> #define GUC_UNIT_XBLOCKS 0x3000 /* value is in xlog blocks */
> #define GUC_UNIT_MB 0x4000 /* value is in megabytes */
> -#define GUC_UNIT_BYTE 0x8000 /* value is in bytes */
> +#define GUC_UNIT_BYTE 0x5000 /* value is in bytes */
> #define GUC_UNIT_MEMORY 0xF000 /* mask for size-related units */
>
> #define GUC_UNIT_MS 0x10000 /* value is in milliseconds */
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-09-06 05:50:59 | pgsql: Fix headerscheck in vpath builds |
| Previous Message | John Naylor | 2022-09-06 05:38:19 | pgsql: Fix failure to maintainer-clean jsonpath_gram.h |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-09-06 05:53:07 | Re: Patch to address creation of PgStat* contexts with null parent context |
| Previous Message | Tom Lane | 2022-09-06 05:42:53 | Re: Modernizing our GUC infrastructure |