| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | constzl <const_sunny(at)126(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Is Backgroundworker.bgw_restart_time is defined in seconds? |
| Date: | 2021-08-26 08:09:36 |
| Message-ID: | 5FD75B47-1F5F-470F-B349-0B54614A49A2@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 26 Aug 2021, at 09:38, constzl <const_sunny(at)126(dot)com> wrote:
> if ((worker->bgw_restart_time < 0 &&
> worker->bgw_restart_time != BGW_NEVER_RESTART) ||
> (worker->bgw_restart_time > USECS_PER_DAY / 1000))
>
> > The Backgroundworker.bgw_restart_time is defined in seconds,
> > so should it be "USECS_PER_DAY / 1000,000" here instead of "USECS_PER_DAY / 1000"?
> > Or am I getting it wrong?
bgw_restart_time is defined as "It can be any positive value” in the docs, see:
https://www.postgresql.org/docs/current/bgworker.html
My reading of the above code is that is tries to catch nonsensical values, not
to cap it to enforce restarts within a 24h period.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | constzl | 2021-08-26 08:36:44 | Re:Re: Is Backgroundworker.bgw_restart_time is defined in seconds? |
| Previous Message | constzl | 2021-08-26 07:38:12 | Is Backgroundworker.bgw_restart_time is defined in seconds? |