| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH v2] use has_privs_for_role for predefined roles |
| Date: | 2021-11-10 17:45:28 |
| Message-ID: | 5F9388A2-35EA-4DAA-BE05-68D55EEA6DC3@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/8/21, 2:19 PM, "Joshua Brindle" <joshua(dot)brindle(at)crunchydata(dot)com> wrote:
> Thanks for the review, attached is an update with that comment fixed
> and also sgml documentation changes that I missed earlier.
I think there are a number of documentation changes that are still
missing. I did a quick scan and saw the "is member of" language in
func.sgml, monitoring.sgml, pgbuffercache.sgml, pgfreespacemap.sgml,
pgrowlocks.sgml, pgstatstatements.sgml, and pgvisibility.sgml.
<para>
By default, the <structname>pg_shmem_allocations</structname> view can be
- read only by superusers or members of the <literal>pg_read_all_stats</literal>
- role.
+ read only by superusers or roles with privilges of the
+ <literal>pg_read_all_stats</literal> role.
</para>
</sect1>
nitpick: "privileges" is misspelled.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-11-10 17:51:15 | Re: emit recovery stats via a new file or a new hook |
| Previous Message | Bharath Rupireddy | 2021-11-10 17:40:00 | Re: wait event and archive_command |