Re: Update stale code comment in CheckpointerMain()

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Update stale code comment in CheckpointerMain()
Date: 2021-12-01 13:24:26
Message-ID: 5B10E53F-CF94-48B1-9EDA-D36A3CDC3F61@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1 Dec 2021, at 07:19, Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> On Tue, Nov 30, 2021 at 3:09 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 30 Nov 2021, at 08:00, Amul Sul <sulamul(at)gmail(dot)com> wrote:
>>
>>> The attached patch updates the code comment which is no longer true
>>> after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd
>>
>> Agreed, but looking at this shouldn't we also tweak the comment on
>> RecoveryInProgress() as per the attached v2 diff?
>
> Yes, we should -- diff looks good to me, thanks.

Thanks for confirming, I've applied this to master.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-12-01 13:36:17 Re: Non-superuser subscription owners
Previous Message Amit Kapila 2021-12-01 13:16:24 Re: Optionally automatically disable logical replication subscriptions on error