Re: Enable data checksums by default

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enable data checksums by default
Date: 2024-11-13 08:31:16
Message-ID: 5951f2ca-d00c-420f-93ea-38e37e4076b2@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07.11.24 19:38, Alvaro Herrera wrote:
> I have just noticed that since this patch was committed as 04bec894a04c,
> pg_upgrade's "make check" action is unusable when given the
> "olddump/oldinstall" options. We now need to inject '-k' to the initdb
> line for old servers, and we don't, so all upgrade tests fail. I think
> this patch should be enough to fix it.

Yes, this fix looks correct. (Or the other way around: Disable
checksums on the new node.)

Is this not being covered by the build farm? Are the upgrade tests
there not using this?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-11-13 08:39:06 Re: Converting contrib SQL functions to new style
Previous Message Ronan Dunklau 2024-11-13 08:15:08 Re: Converting contrib SQL functions to new style