| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Subject: | Re: Removing unneeded self joins |
| Date: | 2025-02-10 05:19:49 |
| Message-ID: | 5934ce1e-be02-4640-904c-f7fec3962784@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/2/2025 18:41, Alexander Korotkov wrote:
> Regarding adjust_relid_set() and replace_relid(). I think they are
> now strictly equivalent, except for the case then old relid is given
> and not found. In this case adjust_relid_set() returns the original
> relids while replace_relid() returns a copy. The behavior of
> adjust_relid_set() appears more desirable as we don't need extra
> copying when no modification is done. So, I've replaced all
> replace_relid() with adjust_relid_set().
Ok, I glanced into it, and it makes sense to merge these routines.
I think the comment to adjust_relid_set() should be arranged, too. See
the attachment for a short variant of such modification.
>
> Also, I did some grammar correction to your new comment in tests.
Thanks!
--
regards, Andrei Lepikhov
| Attachment | Content-Type | Size |
|---|---|---|
| comment.diff | text/plain | 833 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-02-10 06:03:02 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Zhang Mingli | 2025-02-10 05:15:58 | Re: Virtual generated columns |