Re: [HACKERS] PoC: custom signal handler for extensions

From: Maksim Milyutin <milyutinma(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] PoC: custom signal handler for extensions
Date: 2018-03-05 16:24:48
Message-ID: 590e3bc2-0eb3-322c-3c1f-4e79ff562bfe@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello David,

On 05.03.2018 18:50, David Steele wrote:
> Hello Maksim,
>
> On 1/27/18 2:19 PM, Arthur Zakirov wrote:
>
>> Is there actual need in UnregisterCustomProcSignal() within _PG_init()?
>> An extension registers a handler and then unregister it doing
>> nothing. It seems useless.
>>
>> Also process_shared_preload_libraries_in_progress within _PG_fini() will
>> be false I think. _PG_fini() won't be called though, because
>> implementation of internal_unload_library() is disabled.
>>
>> Actually, is there need in UnregisterCustomProcSignal() at all? It
>> unregisters a handler only in current backend, for actual unergistering
>> we need to call it everywhere, if I'm not mistaken.
> This patch has been in Waiting on Author state for almost three weeks.
> Have you had a chance to consider Arthur's suggestions?

Yes, I want to rework my patch to enable setup of custom signals on
working backend without preload initialization.

> Do you know when you'll have an updated patch available?

I want to actuate the work on this patch for the next 12 release. Sorry,
for now I can not keep up with the current release.

--
Regards,
Maksim Milyutin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Sontakke 2018-03-05 16:37:01 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Michael Banck 2018-03-05 16:07:36 Re: [PoC PATCH] Parallel dump to /dev/null