Re: explain analyze rows=%.0f

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, vignesh C <vignesh21(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: explain analyze rows=%.0f
Date: 2025-01-13 20:18:18
Message-ID: 58bb3a5b-c92a-408c-b02a-f47aedc1c0e2@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11.01.2025 14:10, Ilia Evdokimov wrote:
>
>
> On 11.01.2025 12:15, Guillaume Lelarge wrote:
>>
>>
>> Thanks for your patch, this looks like a very interesting feature
>> that I'd like to see in a future release.
>>
>> It did a quick run: patch OK, make OK, make install OK, but make
>> check fails quite a lot on partition_prune.sql.
>>
>> I guess it would need some work on partition_prune.sql tests and
>> perhaps also on the docs.
>>
>> Thanks again.
>>
>>
>> --
>> Guillaume.
>
>
> Yes, certainly. I have fixed partition_prune.sql. In the documentation
> example for EXPLAIN ANALYZE where loops is greater than one, I updated
> how 'rows' and 'loops' values are displayed so they appear as decimal
> fractions with two digits after the decimal point.
>
> I attached fixed patch.
>
> Any suggestions?
>
> --
> Best regards,
> Ilia Evdokimov,
> Tantor Labs LLC.
>

I guess, it's not ideal to modify the existing example in the
documentation of the v5 patch because readers wouldn't immediately
understand why decimal fractions appear there. Instead, I'll add a brief
note in the documentation clarifying how rows and loops are displayed
when the average row count is below one.

The changes the of documentation are attached v6 patch.

If you have any other suggestions or different opinions, I'd be happy to
discuss them.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

Attachment Content-Type Size
v6-0001-Clarify-display-of-rows-and-loops-as-decimal-fraction.patch text/x-patch 7.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-01-13 20:21:04 Re: New GUC autovacuum_max_threshold ?
Previous Message Jeff Davis 2025-01-13 20:09:54 Re: Incorrect CHUNKHDRSZ in nodeAgg.c