| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, zxwsbg12138(at)gmail(dot)com, david(dot)zhang(at)highgo(dot)ca |
| Subject: | Re: Requiring recovery.signal or standby.signal when recovering with a backup_label |
| Date: | 2023-10-16 15:48:43 |
| Message-ID: | 58a6e18b112b4cd8bd9ab66d3f0ff5e77ada8799.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2023-10-16 at 14:54 +0900, Michael Paquier wrote:
> Thanks for the review. Yes, I am wondering if other people would
> chime in here. It doesn't feel like this has gathered enough
> opinions.
I don't have strong feelings either way. If you have backup_label
but no signal file, starting PostgreSQL may succeed (if the WAL
with the checkpoint happens to be in pg_wal) or it may fail with
an error message. There is no danger of causing damage unless you
remove backup_label, right?
I cannot think of a use case where you use such a configuration on
purpose, and the current error message is more crypric than a plain
"you must have a signal file to start from a backup", so perhaps
your patch is a good idea.
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2023-10-16 15:56:10 | Re: Fix output of zero privileges in psql |
| Previous Message | David Steele | 2023-10-16 15:45:07 | Re: The danger of deleting backup_label |