| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | ikedarintarof <ikedarintarof(at)oss(dot)nttdata(dot)com> |
| Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: doc: modify the comment in function libpqrcv_check_conninfo() |
| Date: | 2024-07-09 12:33:33 |
| Message-ID: | 5899b3bf-8a34-46bb-ae75-6847828bb942@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/07/09 15:56, ikedarintarof wrote:
>> - * Validate connection info string, and determine whether it might cause
>> - * local filesystem access to be attempted.
>> + * The function
>> + * 1. validates connection info string and
>> + * 2. checks a password is provided if must_use_password is true.
>>
>> IMO, "Validate connection info string" is sufficient. The mention of
>> must_use_password is redundant since it's explained in the latter part of
>> the comment.
>
> That is reasonable for me. I've removed the second one.
> The modified patch is attached.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2024-07-09 12:48:48 | Re: Address the -Wuse-after-free warning in ATExecAttachPartition() |
| Previous Message | Dean Rasheed | 2024-07-09 12:01:35 | Re: Optimize numeric multiplication for one and two base-NBASE digit multiplicands. |