Re: tsearch_extras extension

From: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
To: Tim Abbott <tabbott(at)mit(dot)edu>, Zev Benjamin <zev(at)mit(dot)edu>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <obartunov(at)gmail(dot)com>
Subject: Re: tsearch_extras extension
Date: 2016-02-17 11:14:57
Message-ID: 58871EEB-A51A-48CE-B3E6-A4CB4C5CC905@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On 17 Feb 2016, at 08:14, Oleg Bartunov <obartunov(at)gmail(dot)com> wrote:
>
>
>
> On Wed, Feb 17, 2016 at 6:57 AM, Tim Abbott <tabbott(at)mit(dot)edu> wrote:
> Just following up here since I haven't gotten a reply -- I'd love to work with someone from the Postgres community on a plan to make the tsearch_extras functionality available as part of mainline postgres.
>
>
> -Tim Abbott
>
> On Wed, Feb 3, 2016 at 9:41 PM, Tim Abbott <tabbott(at)mit(dot)edu> wrote:
> Hello,
>
> I'm a maintainer of the Zulip open source group chat application. Zulip depends on a small (~200 lines) postgres extension called tsearch_extras (https://github.com/zbenjamin/tsearch_extras) that returns the actual (offset, length) pairs of all the matches for a postgres full text search query. This extension allows Zulip to do its own highlighting of the full text search matches, using a more complicated method than what Postgres supports natively.
>
> I think tsearch_extras is probably of value to others using postgres full-text search (and I'd certainly love to get out of the business of maintaining an out-of-tree postgres extension), so I'm wondering if this feature (or a variant of it) would be of interest to upstream?
>
> Thanks!
>
> -Tim Abbott
>
> (See http://www.postgresql.org/message-id/flat/52C7186D(dot)8010504(at)strangersgate(dot)com#52C7186D(dot)8010504@strangersgate.com for the discussion on postgres mailing lists that caused us to write this module in the first place.)
>
> Tim,
>
> take a look on this patch (https://commitfest.postgresql.org/7/385/) and contact author. It contains everything you need to your purposes.
>
> btw, Stas, check on status "Returned with feedback" !
>
>
> Regards,
> Oleg
>

Hi,

Yes, this extension have some common functionality with patch. Particularly yours tsvector_lexemes and mine to_array do the same thing. I wasn’t aware of you patch when started to work on that, so I think we can ask commiter to mention you in commit message (if it that will be commited).

And how do you use ts_match_locs_array / ts_match_locs_array? To highlight search results? There is function called ts_headline that can mark matches with custom start/stop strings.

---
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Raiskup 2016-02-17 11:43:40 Re: [HACKERS] Packaging of postgresql-jdbc
Previous Message Konstantin Knizhnik 2016-02-17 10:39:47 Re: pglogical - logical replication contrib module