Re: Patch review: make RAISE without arguments work like Oracle

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Piyush Newe <piyush(dot)newe(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch review: make RAISE without arguments work like Oracle
Date: 2010-08-09 02:29:17
Message-ID: 5848.1281320957@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

David Fetter <david(at)fetter(dot)org> writes:
> I'd like to mark this as Ready for Committer :)

Applied with corrections. The main noncosmetic change was that the
estate field has to be saved and restored, not just arbitrarily reset to
null after running a handler. Otherwise nested exception handlers
interfere with each other in surprising ways.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Brendan Jurd 2010-08-09 03:06:14 Re: patch: to_string, to_array functions
Previous Message Josh Berkus 2010-08-09 00:40:51 Re: pg_stat_user_functions' notion of user

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Kevin Grittner 2010-08-12 15:43:06 CommitFest 2010-07 week four progress report
Previous Message Tom Lane 2010-08-08 19:18:17 Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function