Re: Converting contrib SQL functions to new style

From: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: Converting contrib SQL functions to new style
Date: 2024-11-06 09:51:29
Message-ID: 5829980.DvuYhMxLoT@aivenlaptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mercredi 6 novembre 2024, 06:52:16 heure normale d’Europe centrale Michael
Paquier a écrit :
> On Tue, Nov 05, 2024 at 08:05:16PM -0500, Tom Lane wrote:
> > No, I don't think so. For one thing, it would not help existing
> > installations unless they issue "ALTER EXTENSION UPDATE", which
> > people are not likely to do in a minor update. But also, we don't
> > know of live attacks against these functions with their current
> > definitions, so I don't think this is urgent.
>
> OK, thanks.

For most of them I agree, but one side effect of the current implementation is
that we have a bug when pg_upgrad'ing if earthdistance is installed:
https://www.postgresql.org/message-id/flat/
152106914669.1223.5104148605998271987%40wrigleys.postgresql.org

The new version of earthdistance fixes that problem, so this one would be worth
a back patch to 16, giving users the opportunity to update earthdistance
before running pg_upgrade.

Thanks for the tip about the CI, will make sure to have it setup before next
time.

--
Ronan Dunklau

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-11-06 10:01:10 Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Previous Message Frédéric Yhuel 2024-11-06 09:47:53 Re: optimize the value of vacthresh and anlthresh