From: | Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] pgpassfile connection option |
Date: | 2016-11-01 13:20:43 |
Message-ID: | 581896AB.7070907@uni-muenster.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Welp, I was in head over heels, sorry for my messy email...
*2. No more "dot_pgpass_used" - we fill the conn->pgpassfile field with
any options that have been provided (connection parameter, environment
variable, "default" ~/.pgpass) and in case there has been an error with
the authentification, we only use conn->pgpassfile in the error message.
Fabien Coelho wrote:
> I agree that it is currently unconvincing. I'm unclear about the
> correct level of messages that should be displayed for a library. I
> think that it should be pretty silent by default if all is well but
> that some environment variable should be able to put a more verbose
> level...
fe_connect.c in general seems very talkative about it's errors - even if
it's only about files not beeing found, so I'll include an error message
for that case next time.
Julian
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-11-01 13:21:19 | Re: Improve output of BitmapAnd EXPLAIN ANALYZE |
Previous Message | Robert Haas | 2016-11-01 13:15:27 | Re: auto_explain vs. parallel query |