Re: plperl tests fail with latest Perl 5.36

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: plperl tests fail with latest Perl 5.36
Date: 2022-06-01 15:40:42
Message-ID: 578876.1654098042@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari(at)ilmari(dot)org> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> Apparently 5.36 rejiggers warning classifications in a way that breaks
>> one of our test cases. Perhaps we should switch it to some other
>> warning-triggering condition.

> The simplest thing is to actually use sort in void context,
> i.e. removing the `my $x = ` part from the test, see the attached.

Looks reasonable to me, but I'm hardly a Perl monk. Anybody have
a different opinion?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2022-06-01 16:35:37 silence compiler warning in brin.c
Previous Message Alvaro Herrera 2022-06-01 15:28:10 Re: support for MERGE