From: | Andreas 'ads' Scherbaum <adsmail(at)wars-nicht(dot)de> |
---|---|
To: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: to_date_valid() |
Date: | 2016-07-03 10:36:04 |
Message-ID: | 5778EA94.1020706@wars-nicht.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 03.07.2016 07:05, Jaime Casanova wrote:
> El 2/7/2016 20:33, "Euler Taveira" <euler(at)timbira(dot)com(dot)br
> <mailto:euler(at)timbira(dot)com(dot)br>> escribió:
> >
> > On 02-07-2016 22:04, Andreas 'ads' Scherbaum wrote:
> > > The attached patch adds a new function "to_date_valid()" which will
> > > validate the date and return an error if the input and output date do
> > > not match. Tests included, documentation update as well.
> > >
> > Why don't you add a third parameter (say, validate = true | false)
> > instead of creating another function? The new parameter could default to
> > false to not break compatibility.
> >
>
> Shouldn't we fix this instead? Sounds like a bug to me. We don't usually
> want to be bug compatible so it doesn't matter if we break something.
There are previous discussions about such a change, and this was rejected:
https://www.postgresql.org/message-id/lbjf1v%24a2v%241%40ger.gmane.org
https://www.postgresql.org/message-id/A737B7A37273E048B164557ADEF4A58B17C9140E%40ntex2010i.host.magwien.gv.at
Hence the new function, which does not collide with the existing
implementation.
Regards,
--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2016-07-03 13:32:46 | Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
Previous Message | Alexander Korotkov | 2016-07-03 10:21:12 | Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |