Re: pgsql: Remove MSVC scripts

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove MSVC scripts
Date: 2023-12-20 15:35:37
Message-ID: 5762e81d-2a2a-b08d-a3ff-f2344a300171@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2023-12-20 We 09:19, Robert Haas wrote:
> On Tue, Dec 19, 2023 at 7:45 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> Remove MSVC scripts
> I think it's because of this commit that koel and crake now have this complaint:
>
> <blah blah lots of output>
> ./src/tools/version_stamp.pl syntax OK
> Can't locate Win32/Registry.pm in @INC (you may need to install the
> Win32::Registry module) (@INC entries checked: src/test/perl
> src/tools/msvc src/backend/catalog src/backend/utils/mb/Unicode
> src/bin/pg_rewind src/test/ssl/t src/tools/msvc/dummylib
> /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38
> /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
> /usr/lib64/perl5 /usr/share/perl5) at ./src/tools/win32tzlist.pl line
> 21.
> BEGIN failed--compilation aborted at ./src/tools/win32tzlist.pl line 21.
>
> win32tzlist.pl still says "use Win32::Registry" but the commit removed
> src/tools/msvc/dummylib/Win32/Registry.pm.
>

Yeah, the commit removed our dummy version of Win32/Registry.pm. I have
disabled the test for that file on branches later than 16, and koel and
crake are back to green.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2023-12-20 18:11:17 Re: pgsql: Remove MSVC scripts
Previous Message Joe Conway 2023-12-20 15:33:14 Re: pgsql: Add support for incremental backup.