| From: | "Nasby, Jim" <nasbyj(at)amazon(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
| Date: | 2018-09-24 19:53:48 |
| Message-ID: | 57414BDC-71F7-4CDD-8A59-3F277C3207ED@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> On Sep 24, 2018, at 1:29 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> I'm very doubtful this is an improvement. Especially with the upcoming
> pluggable storage work making vacuumlazy.c heap specific, while vacuum.c
> stays generic. The concept of something like
> PROC_VACUUM_FOR_WRAPAROUND, should imo not be pushed down that much
> (even if criteria for it might).
That’s already a problem since vacuum logging is spread all over while autovac logging is not. Perhaps there needs to be some sort of vacuum_log() function that immediately provides output for manual vacuums, but aggregates output for autovac. AFAIK that’s the only real reason for autovac logging being a special case today.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-09-24 20:21:04 | pgsql: Fast default trigger and expand_tuple fixes |
| Previous Message | Tom Lane | 2018-09-24 18:41:10 | pgsql: Use ppoll(2), if available, to wait for input in pgbench. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-09-24 20:30:38 | Re: fast default vs triggers |
| Previous Message | Andres Freund | 2018-09-24 19:51:53 | Re: Explain is slow with tables having many columns |