| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Correctly align page's images in generic wal API |
| Date: | 2016-05-16 22:09:17 |
| Message-ID: | 573A450D.6090607@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> Instead of allocating this memory unconditionally for each buffer,
> wouldn't it be better to set all the page pointers to NULL in
> GenericXLogStart and allocate memory only once a buffer is registered
> in GenericXLogRegisterBuffer when finding a free slot? This patch is
> wasting many cycles.
GenericXLogRegisterBuffer() could be called in another MemoryContext what
can be a reason for strange bugs. Right now only a few pages could be
involved in one round of GenericWal. I don't believe that such allocation
could be a reason of noticable performance degradation. Although I didn't
check that.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-05-17 15:29:08 | pgsql: Fix typo |
| Previous Message | Michael Paquier | 2016-05-16 21:47:16 | Re: [COMMITTERS] pgsql: Correctly align page's images in generic wal API |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2016-05-17 00:52:33 | A Modest Upgrade Proposal |
| Previous Message | Michael Paquier | 2016-05-16 21:47:16 | Re: [COMMITTERS] pgsql: Correctly align page's images in generic wal API |