| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent fixups |
| Date: | 2016-05-03 13:25:59 |
| Message-ID: | 5728A6E7.1090306@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/02/2016 10:56 PM, Robert Haas wrote:
> I spent some time going through the output of a trial pgindent run
> today. Some questions/problems:
>
> 1. Is pgindent supposed to touch DATA() lines? Because it does.
Apart from being detabbed/entabbed, no. pgindent protects (or tries to
protect) DATA and CATALOG lines by enclosng them in comments which it
later removes.
>
> 2. CustomPathMethods is not in the buildfarm's typedefs.list. Why not?
Because it's not used anywhere. typdefs get into the list by being used
and thus having a typedef symbol in the compiled binary. Just creating a
typedef isn't enough. This has happened before.
You can get some insight into how the typedefs list is generated by
looking here:
<http://adpgtech.blogspot.com/2015/05/running-pgindent-on-non-core-code-or.html>
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-05-03 13:32:18 | Re: Re: pgsql: Fix assorted inconsistencies in GIN opclass support function dec |
| Previous Message | hari.prasath | 2016-05-03 12:51:36 | full table delete query |