Re: Refactor pg_dump as a library?

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>, Jakob Egger <jakob(at)eggerapps(dot)at>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactor pg_dump as a library?
Date: 2016-04-14 11:16:20
Message-ID: 570F7C04.8030307@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/14/2016 12:22 PM, Craig Ringer wrote:
> I'd find a pg_get_tabledef(...) built-in function more interesting for
> this particular purpose than pg_dump as a library would be. We already
> have pg_get_viewdef(...), pg_get_functiondef(...) etc.

I am personally not a fan of the pg_get_Xdef() functions due to their
heavy reliance on the syscache which feels rather unsafe in combination
with concurrent DDL. I would not be surprised if we have some low
probability bugs which cause inconsistent backups there which just has
not hit enough people yet to have been reported. And this problem will
only get worse as we reduce the lock level of more DDL.

Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2016-04-14 11:26:47 Re: standalone backend PANICs during recovery
Previous Message Bert 2016-04-14 10:35:03 Re: Problems with huge_pages and IBM Power8