Re: Optimization for updating foreign tables in Postgres FDW

On 2016/04/13 21:50, Michael Paquier wrote:
> On Wed, Apr 13, 2016 at 9:46 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Apr 12, 2016 at 10:24 PM, Etsuro Fujita
>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>>> How about we encapsulate the while (PQisBusy(...)) loop into a new
>>>> function pgfdw_get_result(), which can be called after first calling
>>>> PQsendQueryParams()? So then this code will say dmstate->result =
>>>> pgfdw_get_result(dmstate->conn). And we can do something similar for
>>>> the other call to PQexecParams() in create_cursor(). Then let's also
>>>> add something like pgfdw_exec_query() which calls PQsendQuery() and
>>>> then pgfdw_get_result, and use that to replace all of the existing
>>>> calls to PQexec().
>>>>
>>>> Then all the SQL postgres_fdw executes would be interruptible, not
>>>> just the new stuff.

>>> Seems like a good idea. Will do.

>> When will you do this? We are on a bit of a time budget here.

> Fujita-san, I can code that tomorrow or in two days if need be. That
> should not be an issue from here.

I would be happy if you work on that.

Best regards,
Etsuro Fujita