Re: Proposal: BSD Authentication support

On 4/8/16 11:20 AM, Robert Haas wrote:
> On Fri, Apr 8, 2016 at 6:48 AM, Pierre-Emmanuel André <pea(at)openbsd(dot)org> wrote:
>> On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote:
>>> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson <mje(at)insec(dot)sh> wrote:
>>>> On 18/03/16 03:57, Thomas Munro wrote:
>>>>>
>>>>> You used one name in the docs and another in the code:
>>>>>
>>>>> + BSD Authentication on PostgreSQL uses the
>>>>> <literal>auth-postgres</literal>
>>>>> + login type and authenticates with the <literal>postgres</literal>
>>>>> login
>>>>>
>>>>> + retval = auth_userokay(user, NULL, "auth-postgresql", passwd);
>>>>
>>>>
>>>> Woops, fix attached.
>>>
>>> Thanks!
>>>
>>> I'm CCng Pierre-Emmanuel André, maintainer of the OpenBSD postgresql
>>> port/package, just in case he has any feedback.
>>>
>>> Pierre-Emmanuel, here's the full thread in case you missed it:
>>> http://www.postgresql.org/message-id/1521c2f9465.e357a543197915.6912077634413325318@insec.sh
>>
>> Sorry for the late answer.
>> I've tested the patch on @amd64 with the latest PostgreSQL 9.6devel. I can't judge the diff
>> itself (it looks good but i'm not a PostgreSQL developper) but everything works fine.
>> It would be a nice feature to have on OpenBSD.
>
> Opinion poll:
>
> Should we commit this patch?

To summarize:

Robert Haas and Peter Eisentraut have done code-only reviews. Thomas
Munro has reviewed and tested with a caveat that he is no BSD expert.
Pierre-Emmanuel tested but did not do a code review review due to his
unfamiliarity with the Postgres code-base.

The patch does not seem invasive or likely to cause problems on non-BSD
systems. From my perspective this has gotten about as much review as it
can, so +1 from me at least.

--
-David
david(at)pgmasters(dot)net