| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Phrase full text search. |
| Date: | 2016-04-08 08:58:46 |
| Message-ID: | 570772C6.4060808@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
>> Phrase full text search.
>
> Hasn't this patch broken on-disk compatibility of type tsquery by
> renumbering the values of QueryOperator.operator? I'm looking at
> the patch delta in ts_type.h.
Distance field is placed exactly in hole between two uint8_t fields and uint32_t
field, as I known any known platform which we support uses 4-byte aligment for
int32 type. Am I wrong? If yes then I will move distance to the end of struct.
QueryOpertor struct isn't used directly to store to disk, it's used in union
QueryItem.
sizeof(QueryItem) = 12
sizeof(QueryOperator) = 8, so we can add distance to the end without growning
size of QueryItem.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2016-04-08 09:08:17 | pgsql: Rename comparePos() to compareWordEntryPos() |
| Previous Message | Fujii Masao | 2016-04-08 07:49:30 | pgsql: Add regression tests for multiple synchronous standbys. |