Re: pgsql: Add test for postmaster crash restarts.

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add test for postmaster crash restarts.
Date: 2017-09-30 22:21:33
Message-ID: 56b65da3-f7cc-494c-7952-ba5f6c804d7e@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


[re-adding commiters which I inadvertently left off]

On 09/30/2017 06:10 PM, Andres Freund wrote:
>
>
>> I was just looking at this. Why aren't we using "pg_ctl kill" to
>> terminate the backend? That's supposed to be portable.
> Because pg_ctl can't do that for any process but postmaster, no? The
> test is supposed to find issues with backend death (and has
> defficiencies in error reporting already, and would have caught a bug
> I'd introduced previously).
>

No, I don't think so. That's not what the docs say. That's why you give
it a pid argument" "pg_ctl kill signal_name process_id"

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-09-30 22:27:12 Re: pgsql: Add test for postmaster crash restarts.
Previous Message Tom Lane 2017-09-30 21:05:12 pgsql: Fix pg_dump to assign domain array type OIDs during pg_upgrade.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-09-30 22:21:40 Re: 64-bit queryId?
Previous Message Robert Haas 2017-09-30 22:17:37 Re: 64-bit queryId?