Re: New "-b slim" option in 2019b zic: should we turn that on?

On 10/5/19 6:33 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> I've just run into an issue with this (commit a1207910968). The makefile
>> now assumes that zic has this switch. But I was attempting to get around
>> an issue on msys2 by using its zic, (ZIC=/usr/bin/zic configure ...). It
>> crashes on the floor because it doesn't know about "-b slim". I think we
>> probably need a way to turn this off.
> I had contemplated injecting the -b switch via
>
> # any custom options you might want to pass to zic while installing data files
> -ZIC_OPTIONS =
> +ZIC_OPTIONS = -b slim
>
> which would allow overriding it by defining the ZIC_OPTIONS macro.
> Does that seem appropriate? I didn't do it because I worried about
> interference with existing uses of ZIC_OPTIONS ... but who knows
> whether there are any.

I don't think that's going to work very well with a buildfarm member,
where there's no convenient way to set it.

But it turns out there are bigger problems with what I'm doing, anyway,
so let's leave sleeping dogs lie for now.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services