| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christian Ullrich <chris(at)chrullrich(dot)net> |
| Cc: | "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robbie Harwood <rharwood(at)redhat(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: BUG #13854: SSPI authentication failure: wrong realm name used |
| Date: | 2016-03-29 15:09:24 |
| Message-ID: | 56FA9AA4.9090005@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 3/24/16 5:22 PM, Alvaro Herrera wrote:
> Christian Ullrich wrote:
>
>> To be honest, I'm not sure what can and cannot be done in auth code. I
>> took inspiration from the existing SSPI code and nearly every error
>> check in pg_SSPI_recvauth() ends up doing ereport(ERROR) already,
>> directly or via pg_SSPI_error(). If this could cause serious trouble,
>> someone would have noticed yet.
>
> I think the problem is whether the report is sent to the client or not,
> but I may be confusing with something else (COMMERROR reports?).
>
>> What *could* happen, anyway? Can ereport(ERROR) in a backend make the
>> postmaster panic badly enough to force a shared memory reset?
>
> Probably not, since it's running in a backend already at that point, not
> in postmaster.
It seems like this patch should be set "ready for committer". Can one
of the reviewers do that if appropriate?
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-03-29 16:11:03 | Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used |
| Previous Message | Sasikishore.k | 2016-03-29 13:37:29 | BUG #14052: outfile of pg_basebackup , are of different type. But after extractin the file size is same |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2016-03-29 15:18:01 | Re: multivariate statistics v14 |
| Previous Message | Sridhar N Bamandlapally | 2016-03-29 15:09:10 | Re: pg_largeobject |