| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Updated backup APIs for non-exclusive backups |
| Date: | 2016-03-22 16:08:31 |
| Message-ID: | 56F16DFF.4040200@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Magnus,
On 3/19/16 8:15 AM, Magnus Hagander wrote:
> I've attached an updated patch, which is rebased on current master and
> includes the oid fix.
Before doing a thorough review of this patch there are a few points I
would like to consider:
* I think it's really important to provide the stop time in some fashion
when using this new technique. I would prefer a new column to be
returned from pg_stop_backup() but I could live with STOP TIME being
recorded in the label file. STOP TIME should probably be included in
the label file anyway.
* It seems like STOP WAL LOCATION should now also be recorded in the
label file. Preferably this would used by recovery to determine when
the database has reach consistency but that could be a future patch.
I'm not very happy with the current method of using pg_control to get
this information as it assumes that pg_control is copied last (at least
based on the code comments).
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-03-22 16:14:18 | Re: Updated backup APIs for non-exclusive backups |
| Previous Message | Teodor Sigaev | 2016-03-22 16:08:10 | Re: [PATCH] we have added support for box type in SP-GiST index |