Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Date: 2016-03-17 17:31:01
Message-ID: 56EAE9D5.9020203@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> If that's to be an actual GUC variable, it's not okay for set_limit()
> to just do this:
>
> similarity_threshold = nlimit;
>
> It should go through SetConfigOption(); compare for example
> tsa_set_curcfg_byname(). Which would also mean you could drop the
> range-checking code there, because guc.c would enforce it.

will fix

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2016-03-17 17:59:28 Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()
Previous Message Tom Lane 2016-03-17 17:11:52 Re: pgsql: GUC variable pg_trgm.similarity_threshold insead of set_limit()