From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | kgrittn(at)gmail(dot)com |
Cc: | Roma Sokolov <sokolov(dot)r(dot)v(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, pgsql-hackers(at)postgresql(dot)org, Женя Зайцев <zevlg(at)yandex(dot)ru> |
Subject: | Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator |
Date: | 2016-03-15 18:00:50 |
Message-ID: | 56E84DD2.5040904@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Kevin,
On 3/1/16 11:08 AM, Roma Sokolov wrote:
>> On 27 Feb 2016, at 03:46, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
>> Because it is not a common practice to test catalog dependency on
>> separate tests (AFAICS initial catalogs are tested with oidjoins.sql).
>> Also, your test case is too huge for such a small use case.
>
> It seems oidjoins.sql is automatically generated and contains tests only for
> initial database state. On the other hand, there are tests for CREATE OPERATOR
> and ALTER OPERATOR, so it seems reasonable to me to have separate DROP OPERATOR
> test, or to move all operator related testing to one file. This is however
> clearly outside of the scope of this patch, so in v3 I've simplified tests using
> queries from oidjoins.sql.
You've signed up to review this patch, do you have an idea of when you
might be able to do the review?
Thanks,
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-03-15 18:21:34 | Re: Idle In Transaction Session Timeout, revived |
Previous Message | David Steele | 2016-03-15 17:55:24 | Re: IF (NOT) EXISTS in psql-completion |