| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PROPOSAL] Client Log Output Filtering |
| Date: | 2016-03-10 16:00:36 |
| Message-ID: | 56E19A24.9070305@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/03/16 15:08, David Steele wrote:
>> Looking at the code, this adds bool hide_from_client to edata which is
>> not initialized in errstart so that needs to be fixed.
>
> I figured this would take care of it:
>
> MemSet(edata, 0, sizeof(ErrorData));
>
> Since I want hide_from_client to default to false. Am I missing something?
>
Right, missed that, sorry for the noise.
I have another issue though.
The comment above errhidefromclient says "Only log levels below ERROR
can be hidden from the client." but use of the errhidefromclient(true)
actually does hide the error message from client, client just gets
failed query without any message when used with ERROR level.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2016-03-10 16:02:43 | Re: Add generate_series(date,date) and generate_series(date,date,integer) |
| Previous Message | Robert Haas | 2016-03-10 15:58:43 | Re: Add generate_series(date,date) and generate_series(date,date,integer) |