| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Badly designed error reporting code in controldata_utils.c |
| Date: | 2016-03-07 01:16:42 |
| Message-ID: | 56DCD67A.3050505@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/06/2016 01:26 PM, Joe Conway wrote:
> On 03/06/2016 01:24 PM, Tom Lane wrote:
>> * It's randomly unlike every single other place we've addressed the
>> same problem. Everywhere else in src/common does it like this:
[...snip...]
>> and I think that's what this needs to do too, especially in view of the
>> fact that there are only two places that would have to be fixed anyway.
>
> Ok, will fix.
Something like the attached what you had in mind?
Thanks,
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
| Attachment | Content-Type | Size |
|---|---|---|
| controldata-err.diff | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-07 01:19:41 | Re: The plan for FDW-based sharding |
| Previous Message | Fabrízio de Royes Mello | 2016-03-07 01:09:20 | gzclose don't set properly the errno in pg_restore |