| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan |
| Date: | 2016-01-21 10:55:35 |
| Message-ID: | 56A0B927.7050105@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/01/21 7:04, Alvaro Herrera wrote:
> Etsuro Fujita wrote:
>> On second thought, I noticed that detecting whether we see a system column
>> that way needs more cycles in cases where the reltargetlist and the
>> restriction clauses don't contain any system columns. ISTM that such cases
>> are rather common, so I'm inclined to keep that code as-is.
> Ah, I see now what you did there. I was thinking you'd have the
> foreach(restrictinfo) loop, then once the loop is complete scan the
> bitmapset; not scan the bitmap set scan inside the other loop.
Ah, I got to the point. I think that is a good idea. The additional
cycles for the worst case are bounded and negligible. Please find
attached an updated patch.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| create-foreignscan-plan-v4.patch | application/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dang Minh Huong | 2016-01-21 11:05:37 | Re: Window2012R2: initdb error: "The current directory is invalid." |
| Previous Message | Vitaly Burovoy | 2016-01-21 10:51:27 | Re: custom function for converting human readable sizes to bytes |