| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, masao(dot)fujii(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Some bugs in psql_complete of psql |
| Date: | 2016-01-17 02:09:26 |
| Message-ID: | 569AF7D6.9090107@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/12/16 9:46 PM, Peter Eisentraut wrote:
> On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote:
>> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch
>>
>> Fixes completion for CREATE INDEX in ordinary way.
>
> This part has been fixed in another thread. Please check whether that
> satisfies all your issues.
>
>> 3. 0002-Fix-tab-completion-for-DROP-INDEX.patch
>>
>> Fix of DROP INDEX completion in the type-2 way.
>
> I agree that we could use completion support for DROP INDEX
> CONCURRENTLY, but I would rather not throw IF NOT EXISTS into the same
> patch. We don't have support for IF NOT EXISTS anywhere else. If you
> think about, it's rather unnecessary, because tab completion will
> determine for you whether an object exists.
I have applied a reduced version of the DROP INDEX patch. I think that
covers everything in your submission, but please check.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-01-17 04:37:59 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| Previous Message | Corey Huinker | 2016-01-17 00:47:21 | Re: Declarative partitioning |