Incorrect path in header comment identification

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Incorrect path in header comment identification
Date: 2018-05-14 09:45:19
Message-ID: 5689003B-6A71-464F-B199-A3132787BA65@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Commit ba11258ccb which renamed inet_net_ntop.c in src/backend/utils/adt, and
introduced inet_net_ntop.c in src/ports didn’t update the IDENTIFICATION lines
in the header comments. Is there a reason to keep the old locations rather
than updating to the actual locations as per the below trivial diff?

cheers ./daniel

diff --git a/src/backend/utils/adt/inet_cidr_ntop.c b/src/backend/utils/adt/inet_cidr_ntop.c
index 30b3673789..5a30df16e5 100644
--- a/src/backend/utils/adt/inet_cidr_ntop.c
+++ b/src/backend/utils/adt/inet_cidr_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/backend/utils/adt/inet_cidr_ntop.c
*/

#if defined(LIBC_SCCS) && !defined(lint)
diff --git a/src/port/inet_net_ntop.c b/src/port/inet_net_ntop.c
index f27fda96ca..90dfeed42d 100644
--- a/src/port/inet_net_ntop.c
+++ b/src/port/inet_net_ntop.c
@@ -14,7 +14,7 @@
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
* OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*
- * src/backend/utils/adt/inet_net_ntop.c
+ * src/port/inet_net_ntop.c
*/

#if defined(LIBC_SCCS) && !defined(lint)

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-05-14 10:40:31 Re: Considering signal handling in plpython again
Previous Message Hubert Zhang 2018-05-14 07:56:08 Re: Considering signal handling in plpython again