| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: oldest/newestCommitTs output by pg_controldata |
| Date: | 2015-12-28 18:21:56 |
| Message-ID: | 56817DC4.4080007@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/28/2015 09:53 AM, Alvaro Herrera wrote:
>>> The name is just as misleading at the source-code level, maybe more so
>>> since they're all just numbers in C. +1 for changing it everywhere
>>> before somebody makes a mistake based on the incorrect names.
>>
>> Ok, I'm on it now
>
> Great, thanks.
I think the attached does the job. Note I settled on
(new|old)estCommitTsXid as that seemed most descriptive and not horribly
longer than before. It did mean, however, that I needed to add a single
space to all the output in pg_resetxlog and pg_controldata, which added
a fair amount to the patch size.
It is all fairly straightforward, but given the impending 9.5 release,
it'd be nice if someone has a chance to give this a quick review before
I commit.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
| Attachment | Content-Type | Size |
|---|---|---|
| committsxid.00.diff | text/x-diff | 37.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-12-28 18:23:40 | Re: oldest/newestCommitTs output by pg_controldata |
| Previous Message | Alvaro Herrera | 2015-12-28 17:53:20 | Re: oldest/newestCommitTs output by pg_controldata |