Re: Fwd: [GENERAL] pgxs/config/missing is... missing

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: [GENERAL] pgxs/config/missing is... missing
Date: 2015-12-12 00:25:29
Message-ID: 566B6979.7030701@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On 12/10/15 7:09 PM, Tom Lane wrote:
> Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
>> AFAICT the problem is that missing wasn't included in install or
>> uninstall in config/Makefile. Attached patch fixes that, and results in
>> missing being properly installed in lib/pgxs/config.
>
> I thought we'd more or less rejected that approach in the previous thread.

David Wheeler and I worked on a way to work around this in the pgTap
extension, but AFAICT there's a bug here. The FreeBSD packages seems to
be built without having PERL on the system, so if you try and use it
with PGXS to set PERL, you end up with

PERL = /bin/sh
/usr/local/lib/postgresql/pgxs/src/makefiles/../../config/missing perl

which is coming out of the PGXS makefile. And that would work fine, if
we were actually installing config/missing.

If instead of installing config/missing we want to just drop that file
completely we can do that, but then we should remove it from sorce and
from the makefiles.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Jim Nasby 2015-12-12 00:29:23 Re: Fwd: [GENERAL] pgxs/config/missing is... missing
Previous Message Kevin Grittner 2015-12-11 22:13:21 Re: connections not getting closed on a replica

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-12-12 00:26:38 Re: Bootstrap DATA is a pita
Previous Message Jim Nasby 2015-12-12 00:16:43 Re: Add IS (NOT) DISTINCT to subquery_Op