Re: [pgsql-hackers-win32] Weird new time zone

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>> Right. The problem we are actually faced with is to identify
>> which of the zic timezones is the best match for the system's
>> timezone setting.
>> One of the issues is that it's not clear what "best" means...
>>
>> At the moment I like Oliver Jowett's idea of defining "best"
>> as "the one that matches furthest back".

> Sounds reasonable to me. As long as a clear warning is put in the log
> whenever something is picked that is not a perfect match, so the admin
> is directed at the potential problem and can fix it (by setting the GUC
> timezone variable).

I'm not sure that a log entry is needed --- SHOW TIMEZONE will make it
perfectly clear what zone was selected.

But in any case, I've committed code that implements Oliver's idea.
Could folks take another swipe at it and see if it works well in their
local zones? Also, it'd still be interesting to see if we could #ifdef
out the matching on zone names for Windows and still get reasonable
results.

regards, tom lane