Re: pgsql: Try to convince gcc that TupleQueueRemap never falls off the end

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Try to convince gcc that TupleQueueRemap never falls off the end
Date: 2015-11-07 14:38:30
Message-ID: 563E0CE6.3060308@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 11/6/15 11:06 PM, Robert Haas wrote:
> Try to convince gcc that TupleQueueRemap never falls off the end.
>
> Without this, MacOS gcc version 4.2.1 isn't convinced.

I still see some compiler warnings from this:

tqueue.c: In function ‘tqueueReceiveSlot’:
tqueue.c:124:18: warning: variable ‘tup’ set but not used
[-Wunused-but-set-variable]
tqueue.c: In function ‘TupleQueueRemapTuple’:
tqueue.c:612:7: warning: variable ‘dirty’ set but not used
[-Wunused-but-set-variable]

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-11-07 17:43:49 pgsql: Fix enforcement of restrictions inside regexp lookaround constra
Previous Message Robert Haas 2015-11-07 04:06:23 pgsql: Try to convince gcc that TupleQueueRemap never falls off the end