| From: | Adrian Vondendriesch <adrian(dot)vondendriesch(at)credativ(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
| Cc: | "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Christian Almeida <cbalmeida(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] BUG #12989: pg_size_pretty with negative values |
| Date: | 2015-11-06 17:44:36 |
| Message-ID: | 563CE704.1020104@credativ.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Am 06.11.2015 um 17:06 schrieb Robert Haas:
> On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch
> <Adrian(dot)Vondendriesch(at)credativ(dot)de> wrote:
>> New patch attached and rebased on HEAD
>> (8c75ad436f75fc629b61f601ba884c8f9313c9af).
>
> I've committed this with some modifications:
>
> - I changed the comment for the half_rounded() macros because the one
> you had just restated the code.
> - I tightened up the coding in numeric_half_rounded() very slightly.
> - You didn't, as far as I can see, modify the regression test schedule
> to execute the files you added. I consolidated them into one file,
> added it to the schedule, and tightened up the SQL a bit.
Looks much better now.
>
> Thanks for the patch, and please let me know if I muffed anything.
Thanks for reviewing and improving the changes.
I changed the status to committed.
Regards,
- Adrian
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-11-06 17:53:56 | Re: [BUGS] BUG #12989: pg_size_pretty with negative values |
| Previous Message | Robert Haas | 2015-11-06 17:27:51 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-11-06 17:53:18 | Re: [PATCH] Refactoring of LWLock tranches |
| Previous Message | Robert Haas | 2015-11-06 17:44:04 | Re: extend pgbench expressions with functions |