| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Robins <robins(at)pobox(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Cross-check recent documentation changes |
| Date: | 2015-10-29 08:27:12 |
| Message-ID: | 5631D860.8050602@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/29 17:10, Robert Haas wrote:
> On Thu, Oct 29, 2015 at 2:40 AM, Robins <robins(at)pobox(dot)com> wrote:
>> Was reviewing recent commits, and it seems the following commit adds an
>> extra line to some comments. Just wanted to cross-check if that was
>> intentional.
>
> I don't see that it changed any comments at all?
I think he means error messages, for example, why errmsg is replaced by
errmsg_plural in the concerned source code line (the following change)
- errmsg("database with OID %u must be vacuumed before %d
more multixact members are used",
+ errmsg_plural("database with OID %u must be vacuumed
before %d more multixact member is used",
+ "database with OID %u must be vacuumed
before %d more multixact members are used",
+ MultiXactState->offsetStopLimit - nextOffset +
nmembers,
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2015-10-29 08:39:36 | Re: Re: [BUGS] BUG #13611: test_postmaster_connection failed (Windows, listen_addresses = '0.0.0.0' or '::') |
| Previous Message | Robert Haas | 2015-10-29 08:10:54 | Re: Cross-check recent documentation changes |