| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ATT_FOREIGN_TABLE and ATWrongRelkindError() |
| Date: | 2015-10-23 10:02:29 |
| Message-ID: | 562A05B5.6040506@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/23 18:51, Etsuro Fujita wrote:
> On 2015/10/23 6:06, Robert Haas wrote:
>> Good catch. Committed and back-patched to 9.5.
>
> Thanks, Amit and Robert!
>
> This is really really nitpicking, but I noticed that there is an implicit
> rule concerning the message format in ATWrongRelkindError; if more than
> two objects are present, the message is "\"%s\" is not a foo, bar, or
> baz". ("or" is preceded by a comma!) So, would it be better that the
> former is "\"%s\" is not a table, view, or foreign table"?
Oops! Yeah, I missed the comma there. That seems like a generally
preferred punctuation rule (the comma before conjunction(s) I mean).
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | YUriy Zhuravlev | 2015-10-23 10:07:04 | Re: clearing opfuncid vs. parallel query |
| Previous Message | Etsuro Fujita | 2015-10-23 09:51:02 | Re: ATT_FOREIGN_TABLE and ATWrongRelkindError() |