From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
---|---|
To: | dinesh kumar <dineshkumar02(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] SQL function to report log message |
Date: | 2015-10-22 18:15:55 |
Message-ID: | 562927DB.6050804@BlueTreble.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/22/15 2:20 AM, dinesh kumar wrote:
>
> 2. Using this function, if we provide any "NULL" argument to the function,
> we should either skip it or report it. I see this is what the function
> is doing.
>
> postgres=# SELECT pg_report_log('INFO', 'NULL', false, NULL, NULL);
> INFO: NULL
>
> postgres=# SELECT pg_report_log('INFO', 'NULL', false, 'NULL', 'NULL');
> INFO: NULL
> DETAIL: NULL /-- Are you suggesting to change this behaviour/
> HINT: NULL
It should operate the same as what was decided for RAISE.
I'd say it should also support the remaining RAISE options as well
(COLUMN, CONSTRAINT, DATATYPE, TABLE, SCHEMA).
I think hide_statement is a better name than ishidestmt. It would be
nice if RAISE supported that too...
I think the function should also allow specifying a condition name
instead of a SQL state, same as RAISE does.
In other words, this function and raise should operate exactly the same
unless there's a really strong reason not to. Otherwise it's just going
to create confusion.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
From | Date | Subject | |
---|---|---|---|
Next Message | Euler Taveira | 2015-10-22 18:18:15 | Re: pg_recvlogical fixes |
Previous Message | YUriy Zhuravlev | 2015-10-22 17:40:48 | Re: clearing opfuncid vs. parallel query |