| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Kohei KaiGai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Subject: | Re: Foreign join pushdown vs EvalPlanQual |
| Date: | 2015-10-16 03:28:31 |
| Message-ID: | 56206EDF.2090401@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/10/16 2:14, Robert Haas wrote:
> On Thu, Oct 15, 2015 at 3:04 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I confirmed that an epqtuple of foreign parameterized scan is
>> correctly rejected by fdw_recheck_quals with modified outer
>> tuple.
>>
>> I have no objection to this and have two humble comments.
>>
>> In file_fdw.c, the comment for the last parameter just after the
>> added line seems to be better to be aligned with other comments.
> I've pgindented the file. Any other space we might choose would just
> be changed by the next pgindent run, so there's no point in trying to
> vary.
>> In subselect.c, the added break is in the added curly-braces but
>> it would be better to place it after the closing brace, like the
>> other cases.
> Changed that, and committed.
Thanks, Robert and Horiguchi-san.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2015-10-16 03:32:41 | Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |
| Previous Message | Haribabu Kommi | 2015-10-16 03:10:17 | Re: Parallel Seq Scan |