Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, noah(at)leadboat(dot)com
Subject: Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.
Date: 2015-10-13 13:17:14
Message-ID: 561D045A.1080103@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 10/12/2015 10:45 PM, Michael Paquier wrote:
> On Tue, Oct 13, 2015 at 11:31 AM, Tom Lane wrote:
>> Hmm, well, why wasn't that back-patched? We expect these tests to run
>> on Windows don't we?
> The message related to this particular commit is here:
> http://www.postgresql.org/message-id/55B90161.5090506@iki.fi
> I recall that we discussed about back-patching more such things to
> improve the buildfarm coverage but I guess it fell from other's radar.
> Would you consider pushing any sync-up patch for 9.5 and 9.4 I could
> send? At quick glance, I think that's basically a combination of
> adb4950, 13d856e1, 690ed2b and ff85fc8. Andrew, Noah, Heikki, and
> others feel free to object of course if you think that's an utterly
> bad idea.

In general I think we can be a good deal more liberal about backpatching
the testing regime than we are with production code, where we are always
cautious, and the caution has paid big dividends in our reputation for
stability.

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-10-13 15:21:59 pgsql: On Windows, ensure shared memory handle gets closed if not being
Previous Message Michael Paquier 2015-10-13 02:45:06 Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-10-13 13:48:49 Re: Postgres service stops when I kill client backend on Windows
Previous Message Tom Lane 2015-10-13 13:04:26 Re: pg_ctl/pg_rewind tests vs. slow AIX buildfarm members