Re: [Patch] Windows installer: allow manually setting WIXDIR as appropriate.

From: Nikolai Zhubr <n-a-zhubr(at)yandex(dot)ru>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] Windows installer: allow manually setting WIXDIR as appropriate.
Date: 2015-10-04 13:31:55
Message-ID: 56112A4B.6080202@yandex.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi all,
04.10.2015 7:55, J.F. Oster wrote:
> Hello,
>
> +1
> I proposed the same once but had no feedback.

I'm actually surprised by the very low feedback on the list altogether.

> Nikolai, why doesn't the first version work for you? I have it done similar:

Because if the variable itself contains quotes (and typically it does,
to deal with spaces in paths) then AFAICS command interpreter gets
confused when it sees yet more surrounding quotes in a comparison
operator in a line like you listed below. I'm no expert in cmd.exe
behaviour, but at least on windows xp it caused interpreter errors, so I
just used a simple workaround and it then ran fine.

> if NOT "%WIXDIR%"=="" GOTO WIXDIR_SET
> SET WIXDIR="C:\Program Files (x86)\Windows Installer XML v3\bin"
> :WIXDIR_SET
>
>

Thank you,
Nikolai

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikolai Zhubr 2015-10-04 13:52:46 [PATCH] Fix EVT_STC_PAINTED recursion issue (Was: Re: Repaint lockup in ctlSQLBox::OnPositionStc on windows)
Previous Message J.F. Oster 2015-10-04 04:55:33 Re: [Patch] Windows installer: allow manually setting WIXDIR as appropriate.