Confusing remark about UPSERT in fdwhandler.sgml

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Confusing remark about UPSERT in fdwhandler.sgml
Date: 2015-10-02 08:00:41
Message-ID: 560E39A9.5090006@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following is a remark about UPSERT in fdwhandler.sgml.

<command>INSERT</> with an <literal>ON CONFLICT</> clause does not
support specifying the conflict target, as remote constraints are not
locally known. This in turn implies that <literal>ON CONFLICT DO
UPDATE</> is not supported, since the specification is mandatory there.

ISTM that the sentence "as remote constraints are not locally known" is
somewhat confusing, because check constrains on remote tables can be
defined locally in 9.5. How about "unique constraints or exclusion
constraints on remote tables are not locally known"? Attached is a
patch for that.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
fdwhandler-upsert-remark.patch text/x-patch 930 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-10-02 08:04:19 Re: Confusing remark about UPSERT in fdwhandler.sgml
Previous Message Amit Langote 2015-10-02 07:14:42 Re: [PROPOSAL] VACUUM Progress Checker.