| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: TABLESAMPLE patch is really in pretty sad shape |
| Date: | 2015-09-22 19:28:06 |
| Message-ID: | 5601ABC6.50901@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/19/15 10:46 AM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On 7/23/15 6:39 PM, Tom Lane wrote:
>>> + 2202H E ERRCODE_INVALID_TABLESAMPLE_ARGUMENT invalid_tablesample_argument
>>> + 2202G E ERRCODE_INVALID_TABLESAMPLE_REPEAT invalid_tablesample_repeat
>
>> Where did you get these error codes from? The constants in the SQL
>> standard would map to
>
>> ERRCODE_INVALID_SAMPLE_SIZE
>> ERRCODE_INVALID_REPEAT_ARGUMENT_IN_A_SAMPLE_CLAUSE
>
>> Were you looking at a different standard, or did you intentionally
>> choose to rephrase?
>
> I was looking at SQL:2011. My concern in naming them that way was that
> I wanted to have errcodes that would be general enough for any tablesample
> extension to use, but still be tablesample-specific, ie I don't want them
> to have to fall back on say ERRCODE_INVALID_PARAMETER_VALUE.
Makes sense.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-09-22 19:35:36 | Re: hot_standby_feedback default and docs |
| Previous Message | Amit Kapila | 2015-09-22 19:21:30 | Re: Parallel Seq Scan |